From 2fc130d709412987e792501fd5ee09b87cb4ecc0 Mon Sep 17 00:00:00 2001
From: jeffvli <jeffvictorli@gmail.com>
Date: Tue, 26 May 2026 20:46:17 -0700
Subject: [PATCH] validate mpv extra parameters to prevent empty string param
 (#2058)

---
 src/main/features/core/player/index.ts | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/main/features/core/player/index.ts b/src/main/features/core/player/index.ts
index 95e75d51a..8fd1899ab 100644
--- a/src/main/features/core/player/index.ts
+++ b/src/main/features/core/player/index.ts
@@ -120,8 +120,14 @@ const createMpv = async (data: {
 }): Promise<MpvAPI> => {
     const { binaryPath, extraParameters, properties } = data;
     const resolvedBinaryPath = await resolveMpvBinaryPath(binaryPath);
+    const normalizedExtraParameters = (extraParameters ?? [])
+        .map((param) => param.trim())
+        .filter((param) => param.length > 0);
 
-    const params = uniq([...DEFAULT_MPV_PARAMETERS(extraParameters), ...(extraParameters || [])]);
+    const params = uniq([
+        ...DEFAULT_MPV_PARAMETERS(normalizedExtraParameters),
+        ...normalizedExtraParameters,
+    ]);
 
     const mpv = new MpvAPI(
         {