From 29957780cb1701493dc62f41475112cfd067a509 Mon Sep 17 00:00:00 2001
From: jeffvli <jeffvictorli@gmail.com>
Date: Sat, 3 Jan 2026 16:00:32 -0800
Subject: [PATCH] fix wrong imageRes being used in some cases

---
 src/renderer/components/feature-carousel/feature-carousel.tsx  | 1 +
 src/renderer/components/item-card/item-card.tsx                | 3 +++
 src/renderer/components/item-image/item-image.tsx              | 3 ++-
 .../item-list/item-table-list/columns/image-column.tsx         | 1 +
 .../item-table-list/columns/title-combined-column.tsx          | 2 ++
 src/renderer/features/player/components/left-controls.tsx      | 1 +
 src/renderer/features/player/components/mobile-playerbar.tsx   | 1 +
 .../playlists/components/add-to-playlist-context-modal.tsx     | 1 +
 .../features/search/components/library-command-item.tsx        | 1 +
 src/renderer/features/shared/components/library-header.tsx     | 1 +
 10 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/src/renderer/components/feature-carousel/feature-carousel.tsx b/src/renderer/components/feature-carousel/feature-carousel.tsx
index 454f3b830..b03ccf975 100644
--- a/src/renderer/components/feature-carousel/feature-carousel.tsx
+++ b/src/renderer/components/feature-carousel/feature-carousel.tsx
@@ -122,6 +122,7 @@ const CarouselItem = ({ album }: CarouselItemProps) => {
                             id={album.imageId}
                             itemType={LibraryItem.ALBUM}
                             src={imageUrl}
+                            type="itemCard"
                         />
                         <div className={styles.playButtonOverlay}>
                             <PlayButtonGroup onPlay={handlePlay} />
diff --git a/src/renderer/components/item-card/item-card.tsx b/src/renderer/components/item-card/item-card.tsx
index 3972d5e89..8b00e7a55 100644
--- a/src/renderer/components/item-card/item-card.tsx
+++ b/src/renderer/components/item-card/item-card.tsx
@@ -335,6 +335,7 @@ const CompactItemCard = ({
                     id={data?.imageId}
                     itemType={itemType}
                     src={(data as Album | AlbumArtist | Playlist | Song)?.imageUrl}
+                    type="itemCard"
                 />
                 {isFavorite && <div className={styles.favoriteBadge} />}
                 {hasRating && <div className={styles.ratingBadge}>{userRating}</div>}
@@ -553,6 +554,7 @@ const DefaultItemCard = ({
                     id={data?.imageId}
                     itemType={itemType}
                     src={(data as Album | AlbumArtist | Playlist | Song)?.imageUrl}
+                    type="itemCard"
                 />
                 {isFavorite && <div className={styles.favoriteBadge} />}
                 {hasRating && <div className={styles.ratingBadge}>{userRating}</div>}
@@ -833,6 +835,7 @@ const PosterItemCard = ({
                     id={(data as { imageId: string })?.imageId}
                     itemType={itemType}
                     src={(data as { imageUrl: string })?.imageUrl}
+                    type="itemCard"
                 />
                 {isFavorite && <div className={styles.favoriteBadge} />}
                 {hasRating && <div className={styles.ratingBadge}>{userRating}</div>}
diff --git a/src/renderer/components/item-image/item-image.tsx b/src/renderer/components/item-image/item-image.tsx
index 7422a4cbf..d141f56f8 100644
--- a/src/renderer/components/item-image/item-image.tsx
+++ b/src/renderer/components/item-image/item-image.tsx
@@ -37,6 +37,7 @@ const BaseItemImage = (
         id?: null | string;
         itemType: LibraryItem;
         src?: null | string;
+        type?: keyof z.infer<typeof GeneralSettingsSchema>['imageRes'];
     },
 ) => {
     const { src, ...rest } = props;
@@ -45,7 +46,7 @@ const BaseItemImage = (
         id: props.id,
         imageUrl: src,
         itemType: props.itemType,
-        size: 300,
+        type: props.type,
     });
 
     return (
diff --git a/src/renderer/components/item-list/item-table-list/columns/image-column.tsx b/src/renderer/components/item-list/item-table-list/columns/image-column.tsx
index 633509aff..68228d71f 100644
--- a/src/renderer/components/item-list/item-table-list/columns/image-column.tsx
+++ b/src/renderer/components/item-list/item-table-list/columns/image-column.tsx
@@ -86,6 +86,7 @@ export const ImageColumn = (props: ItemTableListInnerColumn) => {
                         id={item?.imageId}
                         itemType={item?._itemType}
                         src={item?.imageUrl}
+                        type="table"
                     />
                     {isHovered && (
                         <div
diff --git a/src/renderer/components/item-list/item-table-list/columns/title-combined-column.tsx b/src/renderer/components/item-list/item-table-list/columns/title-combined-column.tsx
index ddbe707d1..efae1d0c2 100644
--- a/src/renderer/components/item-list/item-table-list/columns/title-combined-column.tsx
+++ b/src/renderer/components/item-list/item-table-list/columns/title-combined-column.tsx
@@ -103,6 +103,7 @@ export const DefaultTitleCombinedColumn = (props: ItemTableListInnerColumn) => {
                         id={item?.imageId}
                         itemType={item?._itemType}
                         src={item?.imageUrl}
+                        type="table"
                     />
                     {isHovered && (
                         <div
@@ -239,6 +240,7 @@ export const QueueSongTitleCombinedColumn = (props: ItemTableListInnerColumn) =>
                         id={item?.imageId}
                         itemType={item?._itemType}
                         src={item?.imageUrl}
+                        type="table"
                     />
                     {isHovered && (
                         <div
diff --git a/src/renderer/features/player/components/left-controls.tsx b/src/renderer/features/player/components/left-controls.tsx
index fbd36f394..87d1b7eed 100644
--- a/src/renderer/features/player/components/left-controls.tsx
+++ b/src/renderer/features/player/components/left-controls.tsx
@@ -124,6 +124,7 @@ export const LeftControls = () => {
                                         id={currentSong?.imageId}
                                         itemType={LibraryItem.SONG}
                                         loading="eager"
+                                        type="table"
                                     />
                                 </Tooltip>
                                 {!collapsed && (
diff --git a/src/renderer/features/player/components/mobile-playerbar.tsx b/src/renderer/features/player/components/mobile-playerbar.tsx
index 9c3dafdf6..500fff997 100644
--- a/src/renderer/features/player/components/mobile-playerbar.tsx
+++ b/src/renderer/features/player/components/mobile-playerbar.tsx
@@ -95,6 +95,7 @@ export const MobilePlayerbar = () => {
                                             id={currentSong.imageId}
                                             itemType={LibraryItem.SONG}
                                             loading="eager"
+                                            type="table"
                                         />
                                     </Tooltip>
                                 </motion.div>
diff --git a/src/renderer/features/playlists/components/add-to-playlist-context-modal.tsx b/src/renderer/features/playlists/components/add-to-playlist-context-modal.tsx
index 64456f994..0867ff865 100644
--- a/src/renderer/features/playlists/components/add-to-playlist-context-modal.tsx
+++ b/src/renderer/features/playlists/components/add-to-playlist-context-modal.tsx
@@ -561,6 +561,7 @@ const PlaylistTableItem = memo(
                                     className: styles.imageContainer,
                                 }}
                                 itemType={LibraryItem.PLAYLIST}
+                                type="table"
                             />
                         </Flex>
                     </Grid.Col>
diff --git a/src/renderer/features/search/components/library-command-item.tsx b/src/renderer/features/search/components/library-command-item.tsx
index 3dfc3b6b4..13458a7cc 100644
--- a/src/renderer/features/search/components/library-command-item.tsx
+++ b/src/renderer/features/search/components/library-command-item.tsx
@@ -104,6 +104,7 @@ export const LibraryCommandItem = ({
                         id={imageId}
                         itemType={itemType}
                         src={imageUrl}
+                        type="table"
                         width={40}
                     />
                 </div>
diff --git a/src/renderer/features/shared/components/library-header.tsx b/src/renderer/features/shared/components/library-header.tsx
index 8f8a5b172..7d90b2d3d 100644
--- a/src/renderer/features/shared/components/library-header.tsx
+++ b/src/renderer/features/shared/components/library-header.tsx
@@ -142,6 +142,7 @@ export const LibraryHeader = forwardRef(
                             itemType={item.type as LibraryItem}
                             onError={onImageError}
                             src={imageUrl || ''}
+                            type="header"
                         />
                     )}
                 </div>